[riot-notifications] [RIOT-OS/RIOT] cpu/kinetis/rtc: add rtc_set_compensation() (#12280)

benpicco notifications at github.com
Mon Sep 23 11:40:38 CEST 2019


benpicco commented on this pull request.



> @@ -95,6 +96,11 @@ int rtc_get_alarm(struct tm *time);
  */
 void rtc_clear_alarm(void);
 
+/**
+ * @brief Set RTC fine tuning
+ */
+void rtc_set_compensation(int8_t adjust, uint8_t interval);

What are those parameters and how are they used?
I would doubt they are universal for all RTC implementations.

If the compensation values can all be derived from on-SoC information, do you even need to pass parameters?

Also, you write you are calling this on init, but it looks like you forgot to commit that part.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12280#pullrequestreview-291660581
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190923/6187e888/attachment.htm>


More information about the notifications mailing list