[riot-notifications] [RIOT-OS/RIOT] drivers/lis2dh12: add I2C mode (#8419)

benpicco notifications at github.com
Mon Sep 23 18:03:03 CEST 2019


benpicco commented on this pull request.



>      if (_acquire(dev) != BUS_OK) {
-        DEBUG("[lis2dh12] error: unable to acquire SPI bus\n");
+        DEBUG("[lis2dh12] error: unable to acquire the bus\n");
+        return LIS2DH12_NOBUS;
+    }
+
+#ifndef MODULE_LIS2DH12_SPI
+    /* in the current state, the I2C driver expects the bus to be acquired
+     * before the init function is called, so we have to switch order */

Is this still true?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/8419#pullrequestreview-291888016
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190923/022678fe/attachment-0001.htm>


More information about the notifications mailing list