[riot-notifications] [RIOT-OS/RIOT] cpu/sam0_common/periph/uart: implement non-blocking write (#12064)

Kees Bakker notifications at github.com
Mon Sep 23 22:54:45 CEST 2019


Is this a normal (allowed?) way of defining a regular macro?
```
USEMODULE += periph_uart_nonblocking
```
In most cases when I see `#ifdef MODULE_blabla` it means "if module blabla is present". But in this case, `periph_uart_nonblocking` is not a module. It is a macro to select a certain behaviour of the uart module.

Shouldn't we just have a macro (defined through CFLAGS) with a name such as `PERIPH_UART_NONBLOCKING`?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12064#issuecomment-534280411
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190923/5f17acbc/attachment.htm>


More information about the notifications mailing list