[riot-notifications] [RIOT-OS/RIOT] efm32: add support for riotboot (#11940)

Kaspar Schleiser notifications at github.com
Tue Sep 24 15:34:54 CEST 2019


kaspar030 commented on this pull request.



> @@ -8,7 +8,7 @@ BOARD ?= samr21-xpro
 FEATURES_REQUIRED += riotboot
 
 # Disable unused modules
-CFLAGS += -DNDEBUG -DLOG_LEVEL=LOG_NONE
+CFLAGS += -DNDEBUG -DLOG_LEVEL=LOG_NONE -DBOOTLOADER

Well, "RIOT_BOOTLOADER" is just an arbitrary but new name of RIOT's bootloader, "riotboot". Why a new name?

"BOOTLOADER" is quite general, but in this case, we only mean riotboot. Why imply that this means any more than riotboot?

For referencing whether the support code is available, "MODULE_RIOTBOOT" can already be used.

How can people not be of the opinion that "RIOTBOOT" is the right name for this define? :wink:

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11940#discussion_r327616325
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190924/b1b2dd39/attachment.htm>


More information about the notifications mailing list