[riot-notifications] [RIOT-OS/RIOT] efm32: add support for riotboot (#11940)
notifications at github.com
Tue Sep 24 15:50:44 CEST 2019
fjmolinas commented on this pull request.
> @@ -8,7 +8,7 @@ BOARD ?= samr21-xpro
FEATURES_REQUIRED += riotboot
# Disable unused modules
-CFLAGS += -DNDEBUG -DLOG_LEVEL=LOG_NONE
+CFLAGS += -DNDEBUG -DLOG_LEVEL=LOG_NONE -DBOOTLOADER
> How can people not be of the opinion that "RIOTBOOT" is the right name for this define? wink
I would think something that isn't `RIOTBOOT` is better since this isn't necessarily a riotboot boot-loader issue, but for any bootloader, e.g: for a case where e.g. `mcuboot` or similar would be supported, I imagine this initialization would need to be skipped. But that could be changed if and when the need arises.
> Well, "RIOT_BOOTLOADER" is just an arbitrary but new name of RIOT's bootloader, "riotboot". Why a new name?
Ok, you are right.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications