[riot-notifications] [RIOT-OS/RIOT] shell_commands: gnrc_netif: only include LoRA options when LoRA PHY is present (#12295)
notifications at github.com
Tue Sep 24 16:49:49 CEST 2019
miri64 requested changes on this pull request.
> @@ -521,6 +521,7 @@ ifneq (,$(filter sx127%,$(USEMODULE)))
USEMODULE += sx127x
USEMODULE += netif
USEMODULE += lora
+ USEMODULE += netif_cfg_lora
I don't like the name:
1) The shell command is `gnrc_netif` specific, not `netif`.
2) `cfg` implies some configuration related stuff, while it is only related to `shell_commands`
How about `gnrc_netif_cmd_lora` and `gnrc_netif_cmd_%` for the generic version?
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications