[riot-notifications] [RIOT-OS/RIOT] shell_commands: gnrc_netif: only include LoRA options when LoRA PHY is present (#12295)
notifications at github.com
Tue Sep 24 16:53:57 CEST 2019
benpicco commented on this pull request.
> @@ -521,6 +521,7 @@ ifneq (,$(filter sx127%,$(USEMODULE)))
USEMODULE += sx127x
USEMODULE += netif
USEMODULE += lora
+ USEMODULE += netif_cfg_lora
I used `gnrc_netif_phy_%` before, however I noticed a problem: [`Makefile.dep`](https://github.com/RIOT-OS/RIOT/blob/master/Makefile.dep#L100) matches `gnrc_%` and then includes the `gnrc` module.
This leads to a build failure of `tests/driver_sx127x`.
So I had to look for another prefix.
Since this is only relevant for the `ifconfig` shell command, I choose the `shell_` prefix which is still 'save'.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications