[riot-notifications] [RIOT-OS/RIOT] shell_commands: gnrc_netif: only include LoRA options when LoRA PHY is present (#12295)

Martine Lenders notifications at github.com
Tue Sep 24 16:56:30 CEST 2019

miri64 commented on this pull request.

> @@ -521,6 +521,7 @@ ifneq (,$(filter sx127%,$(USEMODULE)))
   USEMODULE += sx127x
   USEMODULE += netif
   USEMODULE += lora
+  USEMODULE += netif_cfg_lora

> I used `gnrc_netif_phy_%` before, however I noticed a problem: [`Makefile.dep`](https://github.com/RIOT-OS/RIOT/blob/master/Makefile.dep#L100) matches `gnrc_%` and then includes the `gnrc` module.

This seems to me to be some weird dependency issue. What exactly is failing for the test in question?

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190924/cd0c31fe/attachment-0001.htm>

More information about the notifications mailing list