[riot-notifications] [RIOT-OS/RIOT] shell_commands: gnrc_netif: only include LoRA options when LoRA PHY is present (#12295)

Martine Lenders notifications at github.com
Tue Sep 24 17:03:50 CEST 2019


miri64 commented on this pull request.



> @@ -521,6 +521,7 @@ ifneq (,$(filter sx127%,$(USEMODULE)))
   USEMODULE += sx127x
   USEMODULE += netif
   USEMODULE += lora
+  USEMODULE += netif_cfg_lora

Yeah. Because your PR puts GNRC dependencies in when they are actually not needed. So:

```suggestion
  ifneq (,$(filter gnrc,$(USEMODULE))
    # Pull in `ifconfig` support for LoRA
    USEMODULE += gnrc_netif_cmd_lora
  endif
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12295#discussion_r327669121
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190924/96279914/attachment.htm>


More information about the notifications mailing list