[riot-notifications] [RIOT-OS/RIOT] gnrc_tcp: allow unknown options (#12298)

Simon Brummer notifications at github.com
Tue Sep 24 19:27:07 CEST 2019


The latest hardening of the gnrc_tcp option parser was a bit too restrictive.

Packets with unknown options were dropped by gnrc_tcp. This leads to problems then communicating with feature complete tcp implementations, since valid options like SACK are often announced in first SYN Packet. Without this PR such a SYN would be dropped by gnrc_tcp.

This PR allows packets with unknown options to be valid as long as they respect the boundaries of the option field and the option minimal length.

You can view, comment on, or merge this pull request online at:

  https://github.com/RIOT-OS/RIOT/pull/12298

-- Commit Summary --

  * gnrc_tcp: allow unknown options

-- File Changes --

    M sys/net/gnrc/transport_layer/tcp/gnrc_tcp_option.c (15)

-- Patch Links --

https://github.com/RIOT-OS/RIOT/pull/12298.patch
https://github.com/RIOT-OS/RIOT/pull/12298.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12298
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190924/abacf7e5/attachment.htm>


More information about the notifications mailing list