[riot-notifications] [RIOT-OS/RIOT] gnrc_tcp: test improvement (#11930)

Martine Lenders notifications at github.com
Tue Sep 24 22:29:54 CEST 2019


miri64 commented on this pull request.



> +# Shorten default TCP timeouts to speedup testing
+MSL_US ?= 1000000
+TIMEOUT_US ?= 3000000
+
+# Mark Boards with insufficient memory
+#BOARD_INSUFFICIENT_MEMORY := airfy-beacon arduino-duemilanove arduino-leonardo arduino-mega2560 \
+#                             arduino-nano arduino-uno arduino-duemilanove b-l072z-lrwan1 hifive1 \
+#                             hifive1b i-nucleo-lrwan1 lsn50 microbit msb-430 msb-430h nrf51dongle \
+#                             nrf6310 nucleo-f030r8 nucleo-f031k6 nucleo-f042k6 nucleo-f070rb \
+#                             saml10-xpro saml11-xpro stm32f0discovery stm32l0538-disco telosb \
+#                             nucleo-f072rb nucleo-f303k8 nucleo-f334r8 nucleo-l031k6 \
+#                             nucleo-l053r8 mega-xplained waspmote-pro wsn430-v1_3b wsn430-v1_4 \
+#                             yunjia-nrf51822 z1 thingy52
+
+# unsupported by ethos: chronos, hamilton, ruuvitag
+#BOARD_BLACKLIST := chronos hamilton ruuvitag

Would have been surprised if those changed, however you forgot the [thingy52](https://ci.riot-os.org/RIOT-OS/RIOT/11930/020a8a7a3ebbd296650fbdc7803d8ebf50315964/output/compile/tests/gnrc_tcp/thingy52:gnu.txt) (update comment accordingly):

```suggestion
BOARD_BLACKLIST := chronos hamilton ruuvitag thingy52
```

> +BOARD ?= native
+TAP ?= tap0
+
+# Shorten default TCP timeouts to speedup testing
+MSL_US ?= 1000000
+TIMEOUT_US ?= 3000000
+
+# Mark Boards with insufficient memory
+#BOARD_INSUFFICIENT_MEMORY := airfy-beacon arduino-duemilanove arduino-leonardo arduino-mega2560 \
+#                             arduino-nano arduino-uno arduino-duemilanove b-l072z-lrwan1 hifive1 \
+#                             hifive1b i-nucleo-lrwan1 lsn50 microbit msb-430 msb-430h nrf51dongle \
+#                             nrf6310 nucleo-f030r8 nucleo-f031k6 nucleo-f042k6 nucleo-f070rb \
+#                             saml10-xpro saml11-xpro stm32f0discovery stm32l0538-disco telosb \
+#                             nucleo-f072rb nucleo-f303k8 nucleo-f334r8 nucleo-l031k6 \
+#                             nucleo-l053r8 mega-xplained waspmote-pro wsn430-v1_3b wsn430-v1_4 \
+#                             yunjia-nrf51822 z1 thingy52

Here you go:

```Makefile
BOARDS_INSUFFICIENT_MEMORY := arduino-duemilanove arduino-leonardo \
                              arduino-mega2560 arduino-nano arduino-uno \
                              hifive1 hifive1b i-nucleo-lrwan1 mega-xplained \
                              msb-430 msb-430h nucleo-f030r8 nucleo-f031k6 \
                              nucleo-f042k6 nucleo-f070rb nucleo-f072rb \
                              nucleo-f303k8  nucleo-f334r8 nucleo-l031k6 \
                              nucleo-l053r8 saml10-xpro saml11-xpro \
                              stm32f0discovery stm32l0538-disco telosb \
                              waspmote-pro wsn430-v1_3b wsn430-v1_4 z1
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11930#pullrequestreview-292686184
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190924/96ec41de/attachment-0001.htm>


More information about the notifications mailing list