[riot-notifications] [RIOT-OS/RIOT] make: add targets to debug dependencies variables (#12004)

Francisco notifications at github.com
Wed Sep 25 10:15:00 CEST 2019


fjmolinas commented on this pull request.

Some general comments regarding code.

> +#
+# @author: Gaëtan Harter <gaetan.harter at fu-berlin.de>
+
+: "${RIOTBASE:="$(cd "$(dirname "$0")/../../../" || exit; pwd)"}"
+
+usage() {
+    echo "Usage: $0 <output_directory>"
+}
+
+
+applications() {
+    make --no-print-directory -C "${RIOTBASE}" info-applications
+}
+
+
+boards() {

As this is implemented it will test against all boards, in #12092 this was limited by setting `ALLBOARDS`, I feel like it would be better if `boards` and `applications` where script optional arguments.

> +#
+#     BOARD=board_name make dependency_debug
+#
+# To compare in an aggregated file, you can run in an application directory:
+#
+#    for board in $(make info-boards); do DEPENDENCY_DEBUG_OUTPUT_DIR=bin/info BOARD=${board} make dependency_debug; done; cat bin/info/* > bin/deps_info
+#    DEPENDENCY_DEBUG=1 DEPENDENCY_DEBUG_OUTPUT_DIR=bin/info-global make info-boards-supported; cat bin/info-global/* > bin/deps_info-boards-supported
+#    # And compare both files
+#    diff -u bin/deps_info bin/deps_info-boards-supported
+#
+# And when comparing two revisions, include the revision in the file names
+
+.PHONY: dependency_debug
+# Only generate the dependencies when the board is not disabled
+# This will allow comparing with the output of `info-boards-supported` more easily
+dependency_debug:

Just a style remark, why `"_"` most recipe we have use `"-"` as far as I can tell.

> @@ -0,0 +1,51 @@
+# Debug targets to evaluate dependency migrations
+#
+# The goal is to get the value of variables used for dependency resolution
+# and the impact of refactoring
+
+# Files output can be generated through `info-boards-supported` evaluation with

This returns incorrect resolution in some cases if I'm understanding right from your PR description, right?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12004#pullrequestreview-292893761
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190925/793d1a1d/attachment.htm>


More information about the notifications mailing list