[riot-notifications] [RIOT-OS/RIOT] make: add targets to debug dependencies variables (#12004)

Gaëtan Harter notifications at github.com
Wed Sep 25 13:58:31 CEST 2019


cladmi commented on this pull request.



> +#
+# @author: Gaëtan Harter <gaetan.harter at fu-berlin.de>
+
+: "${RIOTBASE:="$(cd "$(dirname "$0")/../../../" || exit; pwd)"}"
+
+usage() {
+    echo "Usage: $0 <output_directory>"
+}
+
+
+applications() {
+    make --no-print-directory -C "${RIOTBASE}" info-applications
+}
+
+
+boards() {

I do not like duplicating the handling that is done in the build system.

Also, it should normally be executed on everything. It was only to save review time that I limited the boards, but I had to spend an hour justifying that only these boards were affected at the beginning of the testing procedure of #12092 
Also verify there was no side-effect from limiting the boards as there were before https://github.com/RIOT-OS/RIOT/pull/12041 and https://github.com/RIOT-OS/RIOT/pull/11478.

I would rather simplify it when the results are reliable enough.

If you want one board/application, the target can be run alone too. This one is the 'save_all' script.

For limiting applications, `makefiles/app_dirs.inc.mk` currently does not support it, and the implementation of `--applications` in `dist/tools/compile_and_test_for_board` had to compensate for it. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12004#discussion_r328079527
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190925/948f0858/attachment-0001.htm>


More information about the notifications mailing list