[riot-notifications] [RIOT-OS/RIOT] sys: Add Link Format module (#11189)

Leandro Lanzieri notifications at github.com
Thu Sep 26 13:33:21 CEST 2019


> @leandrolanzieri, I apologize for not being more specific in my earlier comments about making elements const. My thinking was that for clif_decode_link() it was reasonable to say we would not modify the input buffer. I agree this reasoning carries through to clif_get_attr().
> 
> I don't think we can carry this through to the clif_attr_t struct in general through because it may be created or used in other contexts besides reading an input string. I'm OK with the const on the 'key' attribute for reasons we discussed earlier.
> 
> Honestly I am not an expert at use of const though, so let me know if you agree.

@kb2ma Sure, sorry about that. It makes sense that the value can be created by the application so it should not be const. Changed!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11189#issuecomment-535462695
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190926/aff46876/attachment.htm>


More information about the notifications mailing list