[riot-notifications] [RIOT-OS/RIOT] riotboot: add riotboot_bootloader pseudomudule (#12307)

Kaspar Schleiser notifications at github.com
Thu Sep 26 15:31:25 CEST 2019


kaspar030 commented on this pull request.



> @@ -145,10 +145,13 @@ riotboot/slot1: $(SLOT1_RIOT_BIN)
 # Default flashing rule for bootloader + slot 0
 riotboot/flash: riotboot/flash-slot0 riotboot/flash-bootloader
 
-# make applications that use the riotboot feature default to actually using it
-# Target 'all' will generate the combined file directly.
+ifeq (,$(filter riotboot_bootloader,$(FEATURES_USED)))

I don't see why not? Do we expect people calling their application "riotboot"?

Anyhow, an alternative to having to add the feature everywhere would be to set "BUILDING_RIOTBOOT=1" in bootloader/riotboot/Makefile and check for that.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12307#discussion_r328613902
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190926/559ef289/attachment-0001.htm>


More information about the notifications mailing list