[riot-notifications] [RIOT-OS/RIOT] riotboot: add riotboot_bootloader pseudomudule (#12307)

Kaspar Schleiser notifications at github.com
Thu Sep 26 16:02:48 CEST 2019


kaspar030 commented on this pull request.



> @@ -145,10 +145,13 @@ riotboot/slot1: $(SLOT1_RIOT_BIN)
 # Default flashing rule for bootloader + slot 0
 riotboot/flash: riotboot/flash-slot0 riotboot/flash-bootloader
 
-# make applications that use the riotboot feature default to actually using it
-# Target 'all' will generate the combined file directly.
+ifeq (,$(filter riotboot_bootloader,$(FEATURES_USED)))

Anyhow, before, we introduced "FLASHFILE = $(RIOTBOOT_EXTENDED_BIN) ". This is wrong in the bootloader case, as riotboot itself behaves like a normal application. So we need to get the information that we're building the bootloader into that file.
Using a feature might seem like a straightforward idea, but that forces us to make changes to completely unrelated files (board / cpu / *). Those might even be external, and they grow.
So that's a bad idea in any case.

Adding a simple "BUILDING_RIOTBOOT=1" to the riotboot makefile can do the same, without the need to add a line everywhere else.

Is makefiles/boot/riotboot.inc.mk" actually supposed to be included when building riotboot itself? Maybe we can skip including it altogether in that case.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12307#discussion_r328630798
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190926/eaf31690/attachment.htm>


More information about the notifications mailing list