[riot-notifications] [RIOT-OS/RIOT] riotboot: add riotboot_bootloader pseudomudule (#12307)

Francisco notifications at github.com
Thu Sep 26 16:19:46 CEST 2019

fjmolinas commented on this pull request.

> @@ -145,10 +145,13 @@ riotboot/slot1: $(SLOT1_RIOT_BIN)
 # Default flashing rule for bootloader + slot 0
 riotboot/flash: riotboot/flash-slot0 riotboot/flash-bootloader
-# make applications that use the riotboot feature default to actually using it
-# Target 'all' will generate the combined file directly.
+ifeq (,$(filter riotboot_bootloader,$(FEATURES_USED)))

> Is makefiles/boot/riotboot.inc.mk" actually supposed to be included when building riotboot itself? Maybe we can skip including it altogether in that case.

I don't think it does, the target `riotboot/flash-bootloader` does though. But we would still have to change the trigger for including `makefiles/boot/riotboot.inc.mk` since right now it is still `FEATURES_USED += riotboot`. It would come down to the same kind of solutions but done elsewhere.  But in this case we would avoid including uneeded targets so your approach sounds better to me.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190926/1ac0d075/attachment.htm>

More information about the notifications mailing list