[riot-notifications] [RIOT-OS/RIOT] cpu/nrf5x: decelare radio_nrfble feat for all nrfs (#12313)
notifications at github.com
Fri Sep 27 10:07:35 CEST 2019
# Contribution description
The `nrfble` driver is working for all nrf-based CPUs (nrf51 and nrf52x), but the `radio_nrfble` feature is right now only and weirdly declared in `boards/common/nrf52/Makefile.features`. So the clean way would obviously be to declare that feature in `cpu/nrf5x_common/Makefile.features`, same as already done for `radio_nrfmin`.
Besides the structural cleanup, this change does furthermore enable `skald` to be build on `nrf51`-based platforms. This is intended and works as expected.
### Testing procedure
`make buildtest` for `examples/skald_x` should build all boards that were build before, and also for all `nrf51`-based ones.
Further, at least one `nrf51`-based board should be flashed with a `skald` example and its behavior should should be verified with any BLE scanner (e.g. use your phone or `examples/nimble_scanner` on any `nrf52`-based board).
### Issues/PRs references
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* cpu/nrf5x: decelare radio_nrfble feat for all nrfs
-- File Changes --
M boards/common/nrf52/Makefile.features (1)
M cpu/nrf5x_common/Makefile.features (1)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications