[riot-notifications] [RIOT-OS/RIOT] gnrc_sixlowpan_frag: move public rbuf functions to their own module (#12318)
notifications at github.com
Fri Sep 27 18:43:53 CEST 2019
The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.
### Contribution description
While implementing [selective fragment recovery](https://tools.ietf.org/html/draft-ietf-6lo-fragment-recovery-05) I ran into the problem of the reassembly buffer being bound to tight to classic reassembly, which makes it basically impossible to use without it. As a first preparation step to factor it out, I moved all its public functions to a new sub-module `gnrc_sixlowpan_frag_rb`. This should simplify the review greatly, as only move stuff around for now (which you can confirm if you activate [diff.colorMoved](https://git-scm.com/docs/git-config#Documentation/git-config.txt-diffcolorMoved) in your git-config.
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes
### Testing procedure
Verify that apart from some header changes and module definition stuff I only move stuff around (I'm assuming the RIOT-OS/RIOT remote is called `upstream` on your system)
git fetch upstream
git diff --color-moved $(git merge-base upstream/master HEAD)
`tests/gnrc_sixlowpan_frag` should still work:
BOARD="<pick one>" make -C tests/gnrc_sixlowpan_frag flash test
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output
### Issues/PRs references
None so far
Examples: Fixes #1234. See also #5678. Depends on PR #9876.
Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* gnrc_sixlowpan_frag: move reassembly buffer to its own header
* gnrc_sixlowpan_frag: move public rbuf functions to their own module
* gnrc_sixlowpan: include reassembly buffer only where needed
-- File Changes --
M Makefile.dep (1)
M sys/Makefile.include (3)
M sys/include/net/gnrc/sixlowpan/frag.h (106)
A sys/include/net/gnrc/sixlowpan/frag/rb.h (140)
M sys/include/net/gnrc/sixlowpan/frag/vrb.h (2)
M sys/net/gnrc/Makefile (3)
M sys/net/gnrc/network_layer/sixlowpan/frag/gnrc_sixlowpan_frag.c (57)
A sys/net/gnrc/network_layer/sixlowpan/frag/rb/Makefile (3)
A sys/net/gnrc/network_layer/sixlowpan/frag/rb/gnrc_sixlowpan_frag_rb.c (85)
M sys/net/gnrc/network_layer/sixlowpan/frag/rbuf.h (2)
M sys/net/gnrc/network_layer/sixlowpan/gnrc_sixlowpan.c (1)
M sys/net/gnrc/network_layer/sixlowpan/iphc/gnrc_sixlowpan_iphc.c (2)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications