[riot-notifications] [RIOT-OS/RIOT] drivers/dfplayer: New driver for the DFPlayer Mini MP3 player (#12271)
notifications at github.com
Mon Sep 30 11:42:50 CEST 2019
Nice! I am using this device since some in my kids record player. Although its running on Arduino at the moment, the kids still love it :-)
When I got my devices, I of course started also to write a RIOT driver on my own: https://github.com/haukepetersen/RIOT/tree/add_driver_dfplayermini. But as always, I did not get to PRing it, mainly as I was missing the time to add all the missing doc.
On first sight, it seems like both drivers offer a very similar interface. The main difference I could find is code size, the driver in this PR takes ~1300 byte ROM, while mine takes ~700 (both @ nrf52dk). The question is, if this is due to some additional features or maybe there is room for improvement.
But anyhow, I would be totally fine with merging this PR as is, and I might PR mine as a leight-weight alternative at some point.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications