[riot-notifications] [RIOT-OS/RIOT] makefiles: introduce 'LIBS' variable (#11111)
notifications at github.com
Mon Sep 30 18:19:41 CEST 2019
I somehow still do not like `LIBS`, I just used it as a placeholder but for me it does not reflect the fact that it is modules whose archive will need to be linked the same way as ld links libraries by default.
But as we did not get a way to describe this directly, @jcarrano initial idea of something like `MODULES_NO_WHOLE_ARCHIVE` would reflect the issue.
> We cannot go (AFAIK) with #8711 as it is incompatible with LTO, an important use-case.
> Is in that case the distinction still necessary?
If we ignore `ld -r` globally, then the naming does not need to be generic and could say `no_whole_archive`.
For me, this list has two goal, we know that some libraries cannot be linked with `--whole-archive`, so it is required to prevent a module to be linked this way.
But the main one, is to more easily enable linking with whole archive in RIOT without fixing anything.
Disable the new linking for all modules that behave differently and add the new linking.
Then, each module can be after investigating/migration/specific testing be fixed and removed from the `no_whole_archive` list.
I would even first list all modules that define a `UNDEF` in it.
Including the new linking should get the same binary size and symbols for everything by removing everything that could change it.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications