[riot-notifications] [RIOT-OS/RIOT] drivers/periph/spi: add periph_spi_reconfigure feature & implementation for sam0 (#13631)

Dylan Laduranty notifications at github.com
Fri May 1 15:54:25 CEST 2020


@dylad commented on this pull request.



> @@ -95,6 +92,22 @@ void spi_init_pins(spi_t bus)
     gpio_init_mux(spi_config[bus].miso_pin, spi_config[bus].miso_mux);
     gpio_init_mux(spi_config[bus].mosi_pin, spi_config[bus].mosi_mux);
     gpio_init_mux(spi_config[bus].clk_pin, spi_config[bus].clk_mux);
+
+    /* wake up device */
+    poweron(bus);

Powering on the bus should go above `dev(bus)->CTRLA.reg |= SERCOM_SPI_CTRLA_SWRST;` 
Otherwise we might end up stuck in while` ((dev(bus)->CTRLA.reg & SERCOM_SPI_CTRLA_SWRST)`

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/13631#pullrequestreview-404170403
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200501/2c076cc9/attachment.htm>


More information about the notifications mailing list