[riot-notifications] [RIOT-OS/RIOT] drivers/nrf24l01p: Netdev driver for nrf24l01p (#13743)

benpicco notifications at github.com
Sun May 3 17:48:25 CEST 2020


@benpicco commented on this pull request.

I finally received my modules and can do some testing now!

After flashing `examples/gnrc_networking` I noticed some failed asserts - you'll need to add `NETDEV_TYPE_NRF24L01P_NG` to `sys/net/link_layer/l2util/l2util.c`.

You probably want to add it in some other places too - I'd say searching for `NETDEV_TYPE_CC110X` is a good guide as that's a similar transceiver.

> + * @brief   Statically allocate memory for interfaces
+ */
+static gnrc_netif_t _netif[NRF24L01P_NG_NUM];
+
+/**
+ * @brief   Statically allocate memory for the MAC layer thread(s)
+ */
+static char stacks[NRF24L01P_NG_NUM][NRF24L01P_NG_MAC_STACKSIZE];
+
+void auto_init_nrf24l01p_ng(void)
+{
+    for (unsigned i = 0; i < NRF24L01P_NG_NUM; i++) {
+        LOG_DEBUG("[auto_init_netif] initializing nrf24l01p #%u\n", i);
+
+        nrf24l01p_ng_setup(&_nrf24l01p_ng_devs[i], &nrf24l01p_ng_params[i]);
+        gnrc_netif_nrf24l01p_ng_create(&_netif[i], stacks[i],

Why not just directly call `gnrc_netif_create()` here?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/13743#pullrequestreview-395566946
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200503/beec3984/attachment.htm>


More information about the notifications mailing list