[riot-notifications] [RIOT-OS/RIOT] drivers/nrf24l01p: Netdev driver for nrf24l01p (#13743)

benpicco notifications at github.com
Sun May 3 18:04:40 CEST 2020


@benpicco commented on this pull request.



> +/**
+ * @brief   Reset value of TX_ADDR register
+ */
+#define NRF24L01P_NG_DEFAULT_TX_ADDR        { 0xE7, 0xE7, 0xE7, 0xE7, 0xE7 }
+
+/**
+ * @brief   Reset value of RX_ADDR_P0 register
+ */
+#define NRF24L01P_NG_DEFAULT_ADDR_P0        { 0xE7, 0xE7, 0xE7, 0xE7, 0xE7 }
+
+/**
+ * @brief   Reset value of RX_ADDR_P1 register
+ */
+#define NRF24L01P_NG_DEFAULT_ADDR_P1        { 0xC2, 0xC2, 0xC2, 0xC2, 0xC2 }

Shouldn't those be obtained through `luid_get()`?
When I flash two boards they will both end up with `E7:E7:E7:E7:E7`

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/13743#pullrequestreview-404632922
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200503/27b2ee2c/attachment.htm>


More information about the notifications mailing list