[riot-notifications] [RIOT-OS/RIOT] cpu/sam0_common: move PWM to common code, add support for saml21, samd5x (#14007)

Dylan Laduranty notifications at github.com
Sun May 3 21:44:53 CEST 2020


@dylad commented on this pull request.

I'll try to look at issues on SAML21 and SAML1X.
TC and TCC are really scatter around, the generic configuration isn't a bad idea I guess.
Could you also rename all the _tcc internal reference (since we can use TC) please ?
This is starting to look like ifdef-land...

> -        return PM_APBCMASK_TCC1;
-    }
-
-    if (tcc == TCC2) {
-        return PM_APBCMASK_TCC2;
-    }
-#ifdef TCC3
-    if (tcc == TCC3) {
-        return PM_APBCMASK_TCC3;
-    }
-#endif
-
-    assert(0);
-    return 0;
-}
-
 static uint8_t get_prescaler(unsigned int target, int *scale)

```suggestion
static uint8_t _get_prescaler(unsigned int target, int *scale)
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/14007#pullrequestreview-404650833
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200503/100eb7d2/attachment.htm>


More information about the notifications mailing list