[riot-notifications] [RIOT-OS/RIOT] sys/ztimer: expose ZTIMER_MSEC/USEC_BASE (#13990)

Juergen Fitschen notifications at github.com
Mon May 4 14:23:36 CEST 2020


@jue89 commented on this pull request.

Some first thoughts ...

> +  FEATURES_OPTIONAL += periph_rtt
+  ifneq (,$(filter periph_rtt,$(FEATURES_USED)))
+    USEMODULE += ztimer_periph_rtt
+  endif

I like this approach! It's heading more in the direction of *it simply works*.

> @@ -107,18 +108,20 @@ ztimer_clock_t *const ZTIMER_USEC = &_ztimer_convert_frac_usec.super.super;
 #if MODULE_ZTIMER_MSEC
 #  if MODULE_PERIPH_RTT

I would change this to `#if MODULE_ZTIMER_PERIPH_RTT`. This should be the correct way to check whether `ZTIMER_MSEC` should be backed by `periph_rtt`.

> +#ifdef XTIMER_HZ
+#define ZTIMER_USEC_BASE_FREQ   (XTIMER_HZ)
+#else

On the first glimpse, this looks like `xtimer` configuration is creeping into `ztimer`. But I don't have any idea how to implement this the *clean way*.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/13990#pullrequestreview-404932576
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200504/6b985d8b/attachment.htm>


More information about the notifications mailing list