[riot-notifications] [RIOT-OS/RIOT] makefiles/docker.inc.mk: add and use generic docker_run_make (#13678)

Alexandre Abadie notifications at github.com
Tue May 5 10:49:46 CEST 2020


@aabadie commented on this pull request.



> @@ -91,8 +90,15 @@ DOCKER_OVERRIDE_CMDLINE += $(strip $(DOCKER_OVERRIDE_CMDLINE_AUTO))
 # Overwrite if you want to use `docker` with sudo
 DOCKER ?= docker
 
-# 'make' arguments inside docker
-DOCKER_MAKE_ARGS += $(DOCKER_MAKECMDGOALS) $(DOCKER_OVERRIDE_CMDLINE)
+# Set default run flags:
+# - allocate a pseudo-tty
+# - remove container on exit
+# - set username/UID to executor
+DOCKER_USER ?= $$(id -u)
+DOCKER_RUN_FLAGS ?= --rm --tty --user $(DOCKER_USER)
+
+# allow setting make args from command line like '-j'
+DOCKER_TARGET_MAKE_ARGS ?=

```suggestion
DOCKER_MAKE_ARGS ?=
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/13678#pullrequestreview-405599922
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200505/5d46fe6e/attachment.htm>


More information about the notifications mailing list