[riot-notifications] [RIOT-OS/RIOT] sys/ztimer: expose ZTIMER_MSEC/USEC_BASE (#13990)

Kaspar Schleiser notifications at github.com
Tue May 5 10:56:53 CEST 2020


@kaspar030 commented on this pull request.



>  /**
  * @brief   Default ztimer microsecond clock
  */
 extern ztimer_clock_t *const ZTIMER_USEC;
 
+/**
+ * @def     ZTIMER_USEC_BASE_FREQ
+ *
+ * @brief   The frequency of the base ztimer for ZTIMER_USEC
+ */
+#ifdef XTIMER_HZ

I see an issue here. I tried to keep all of the ztimer configuration in auto_init.c.
That means that the actual ztimer code compiles from the same headers. Including ztimer.h leads to the same on every platform.
Pulling the configuration here messes with that principle.

A solution would be to change the frequency defines to extern uint32 declarations, and define them in auto_init.c.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/13990#pullrequestreview-405604828
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200505/00ed70d4/attachment.htm>


More information about the notifications mailing list