[riot-notifications] [RIOT-OS/RIOT] cpu/stm32_common: make RTT_FREQUENCY configurable (#13909)

Alexandre Abadie notifications at github.com
Tue May 5 16:45:45 CEST 2020


@aabadie approved this pull request.

Tested on IoT-LAB following the testing procedure:

<details><summary>b-l072z-lrwan1</summary>

```
make BOARD=b-l072z-lrwan1 -C tests/periph_rtt flash test IOTLAB_NODE=auto-ssh
make: Entering directory '/work/riot/RIOT/tests/periph_rtt'
Building application "tests_periph_rtt" for "b-l072z-lrwan1" with MCU "stm32l0".

"make" -C /work/riot/RIOT/boards/b-l072z-lrwan1
"make" -C /work/riot/RIOT/core
"make" -C /work/riot/RIOT/cpu/stm32l0
"make" -C /work/riot/RIOT/cpu/cortexm_common
"make" -C /work/riot/RIOT/cpu/cortexm_common/periph
"make" -C /work/riot/RIOT/cpu/stm32_common
"make" -C /work/riot/RIOT/cpu/stm32_common/periph
"make" -C /work/riot/RIOT/cpu/stm32l0/periph
"make" -C /work/riot/RIOT/drivers
"make" -C /work/riot/RIOT/drivers/periph_common
"make" -C /work/riot/RIOT/sys
"make" -C /work/riot/RIOT/sys/auto_init
"make" -C /work/riot/RIOT/sys/isrpipe
"make" -C /work/riot/RIOT/sys/newlib_syscalls_default
"make" -C /work/riot/RIOT/sys/pm_layered
"make" -C /work/riot/RIOT/sys/stdio_uart
"make" -C /work/riot/RIOT/sys/test_utils/interactive_sync
"make" -C /work/riot/RIOT/sys/tsrb
   text	   data	    bss	    dec	    hex	filename
  10336	    132	   2652	  13120	   3340	/work/riot/RIOT/tests/periph_rtt/bin/b-l072z-lrwan1/tests_periph_rtt.elf
iotlab-node --jmespath='keys(@)[0]' --format='int'  --list saclay,st-lrwan1,1 --flash /work/riot/RIOT/tests/periph_rtt/bin/b-l072z-lrwan1/tests_periph_rtt.bin | grep 0
0
r
ssh -t abadie at saclay.iot-lab.info 'socat - tcp:st-lrwan1-1.saclay.iot-lab.info:20000'
Help: Press s to start test, r to print it is ready
READY
s
START
main(): This is RIOT! (Version: 2020.07-devel-111-gfc644c-review_rtt_frequency)

RIOT RTT low-level driver test
This test will display 'Hello' every 5 seconds

Initializing the RTT driver
RTT now: 0
Setting initial alarm to now + 5 s (5120)
Done setting up the RTT, wait for many Hellos
Hello
Hello
Hello
Hello
Hello

make: Leaving directory '/work/riot/RIOT/tests/periph_rtt'
```

</details>

<details><summary>iotlab-m3</summary>

```
make BOARD=iotlab-m3 -C tests/periph_rtt flash test IOTLAB_NODE=auto-ssh
make: Entering directory '/work/riot/RIOT/tests/periph_rtt'
Building application "tests_periph_rtt" for "iotlab-m3" with MCU "stm32f1".

"make" -C /work/riot/RIOT/boards/iotlab-m3
"make" -C /work/riot/RIOT/boards/common/iotlab
"make" -C /work/riot/RIOT/core
"make" -C /work/riot/RIOT/cpu/stm32f1
"make" -C /work/riot/RIOT/cpu/cortexm_common
"make" -C /work/riot/RIOT/cpu/cortexm_common/periph
"make" -C /work/riot/RIOT/cpu/stm32_common
"make" -C /work/riot/RIOT/cpu/stm32_common/periph
"make" -C /work/riot/RIOT/cpu/stm32f1/periph
"make" -C /work/riot/RIOT/drivers
"make" -C /work/riot/RIOT/drivers/periph_common
"make" -C /work/riot/RIOT/sys
"make" -C /work/riot/RIOT/sys/auto_init
"make" -C /work/riot/RIOT/sys/isrpipe
"make" -C /work/riot/RIOT/sys/newlib_syscalls_default
"make" -C /work/riot/RIOT/sys/pm_layered
"make" -C /work/riot/RIOT/sys/stdio_uart
"make" -C /work/riot/RIOT/sys/test_utils/interactive_sync
"make" -C /work/riot/RIOT/sys/tsrb
   text	   data	    bss	    dec	    hex	filename
  10212	    132	   2652	  12996	   32c4	/work/riot/RIOT/tests/periph_rtt/bin/iotlab-m3/tests_periph_rtt.elf
iotlab-node --jmespath='keys(@)[0]' --format='int'  --list saclay,m3,1 --flash /work/riot/RIOT/tests/periph_rtt/bin/iotlab-m3/tests_periph_rtt.bin | grep 0
0
r
ssh -t abadie at saclay.iot-lab.info 'socat - tcp:m3-1.saclay.iot-lab.info:20000'
READY
s
START
main(): This is RIOT! (Version: 2020.07-devel-111-gfc644c-review_rtt_frequency)

RIOT RTT low-level driver test
This test will display 'Hello' every 5 seconds

Initializing the RTT driver
RTT now: 0
Setting initial alarm to now + 5 s (5)
Done setting up the RTT, wait for many Hellos
Hello
Hello
Hello
Hello
Hello

make: Leaving directory '/work/riot/RIOT/tests/periph_rtt'
```

</details>

Changes are also good to me even if I would have preferred to keep the test application platform agnostic. Anyway I won't block for that.

So ACK



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/13909#pullrequestreview-405860666
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200505/2d43ab46/attachment.htm>


More information about the notifications mailing list