[riot-notifications] [RIOT-OS/RIOT] sys/shell: refactor readline function (#13196)

Gunar Schorcht notifications at github.com
Wed May 6 07:30:22 CEST 2020


@gschorcht requested changes on this pull request.



> @@ -7,9 +7,7 @@ endif
 
 ESP_SDK_DIR = $(ESP32_SDK_DIR)
 
-# With the '-Os' option, the ESP32 hangs sporadically in 'tests/bench*' if
-# interrupts are disabled too early by benchmark tests.
-CFLAGS_OPT ?= -O2
+CFLAGS_OPT ?= -Os

```suggestion
```
`CFLAGS_OPT` is set to `-Os` by default in https://github.com/RIOT-OS/RIOT/blob/8ffd34ddd05627e44193945e8365aeca07899875/cpu/esp_common/Makefile.include#L45

> @@ -7,9 +7,7 @@ endif
 
 ESP_SDK_DIR = $(ESP32_SDK_DIR)
 

```suggestion

```
And remove the additional blank line. Unfortunately, multiline suggestions are not supported for deleted lines :worried:

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/13196#pullrequestreview-406310862
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200505/a8a243cd/attachment.htm>


More information about the notifications mailing list