[riot-notifications] [RIOT-OS/RIOT] cpu/sam0_common: GPIO: use tamper detection to wake from Deep Sleep (#14030)

Juergen Fitschen notifications at github.com
Wed May 6 12:38:19 CEST 2020


@jue89 commented on this pull request.

A few minor comments

> +    GPIO_PIN(PA, 8), GPIO_PIN(PA, 9), GPIO_PIN(PA, 16),
+    GPIO_PIN(PA, 17)

Maybe this should go into the respective `periph_cpu.h`.

> +    GPIO_PIN(PB, 0), GPIO_PIN(PB, 2), GPIO_PIN(PA, 2),
+    GPIO_PIN(PC, 0), GPIO_PIN(PC, 1)

This as well.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/14030#pullrequestreview-406480618
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200506/dd801064/attachment.htm>


More information about the notifications mailing list