[riot-notifications] [RIOT-OS/RIOT] Add hx711 ADC driver and saul (#14039)

Juergen Fitschen notifications at github.com
Thu May 7 15:49:20 CEST 2020


Hey @Citrullin!

Thanks for your contribution! One idea / question that came into my mind while reading over your code: Are there use cases that require one application to acquire different amounts of measurements for averaging?
If not, I would get rid of the `times` parameter and rely on on the configured `dev.params.read_times`. This would simplify the API.

It might be also good to split the driver into two separat commits: One for the driver itself and one for the `saul` wrapper.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/14039#issuecomment-625267224
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200507/344e77da/attachment-0001.htm>


More information about the notifications mailing list