[riot-notifications] [RIOT-OS/RIOT] boards: add support for nrf52840-dongle (#13146)

benpicco notifications at github.com
Thu May 7 18:48:47 CEST 2020


@benpicco commented on this pull request.

Hm we have to remove the `riotboot` feature somehow.

> +    /* initialize the board's button */
+    gpio_init(BTN0_PIN, BTN0_MODE);
+    gpio_set(BTN0_PIN);

No need to init the button. This will be done by the application. `gpio_set()` also makes no sense here.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/13146#pullrequestreview-407654506
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200507/93c987e1/attachment.htm>


More information about the notifications mailing list