[riot-notifications] [RIOT-OS/RIOT] tests/conn_can: Add can tranceiver and pin configuration (#12769)

MrKevinWeiss notifications at github.com
Fri May 8 16:25:53 CEST 2020


@MrKevinWeiss requested changes on this pull request.

Should you also remove the `Linux CAN basic commands` section in the readme as this is only for physical drivers or is it still applicable?

> @@ -112,17 +98,16 @@ static int set_mode(int argc, char **argv) {
         }
         else {
             printf("Error when setting mode: %d\n", res);
+            return 1;

Just have a return 1 at the end, no need repeating them

>          }
     }
     else {
         puts("Invalid trx_id or mode");
+        return 1;

same here

>      }
-
-    return 1;

keep this

> @@ -85,20 +66,25 @@ static int init(int argc, char **argv) {
         }
         else {
             printf("Error when initializing trx: %d\n", res);
+            return 1;

return at the end, why have more lines of code?

>      }
-
-    return 1;

keep this

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12769#pullrequestreview-408274434
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200508/67fcaaac/attachment-0001.htm>


More information about the notifications mailing list