[riot-notifications] [RIOT-OS/RIOT] nrf52840dk: Add MTD configuration (#14052)

Marian Buschsieweke notifications at github.com
Mon May 11 10:50:33 CEST 2020


@maribu approved this pull request.

ACK. Looks good to. Works as advertised.

<details><summary>Test output</summary>

```
make BOARD=nrf52840dk PROGRAMMER=openocd -C tests/pkg_littlefs flash term
[...]
r
2020-05-11 10:47:14,597 # READY
s
2020-05-11 10:47:15,878 # START
2020-05-11 10:47:15,883 # main(): This is RIOT! (Version: 2020.07-devel-181-g4f41c-bergzand)
2020-05-11 10:49:16,573 # ........
2020-05-11 10:49:16,575 # OK (8 tests)
```

</details>

> +    .wait_chip_erase = 50LU * US_PER_SEC,
+    .wait_32k_erase = 240LU *US_PER_MS,
+    .wait_sector_erase = 40LU * US_PER_MS,
+    .wait_4k_erase = 40LU * US_PER_MS,
+    .wait_chip_wake_up = 35LU * US_PER_MS,

It should now be safe to omit the `LU` postfix, if you feel like this. `US_PER_MS` no has an `LU` postfix, so this would make no difference. But I wouldn't mind also keeping it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/14052#pullrequestreview-408975602
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200511/edfbe897/attachment.htm>


More information about the notifications mailing list