[riot-notifications] [RIOT-OS/RIOT] paho-mqtt: building for native board using Lwip package, for the moment example not working (#12647)

Martine Lenders notifications at github.com
Mon May 11 14:37:21 CEST 2020


@miri64 commented on this pull request.



> +From 54b50b97e3b23159808c44311a7ba474909f3e2e Mon Sep 17 00:00:00 2001
+From: Javier FILEIV <javier.fileiv at gmail.com>
+Date: Mon, 21 Oct 2019 13:50:59 +0200
+Subject: [PATCH] mods to RIOT building
+
+
+diff --git a/MQTTClient-C/src/MQTTClient.c b/MQTTClient-C/src/MQTTClient.c
+index bd24dff..4326021 100755
+--- a/MQTTClient-C/src/MQTTClient.c
++++ b/MQTTClient-C/src/MQTTClient.c
+@@ -363,7 +363,7 @@ int MQTTIsConnected(MQTTClient* client)
+   return client->isconnected;
+ }
+ 
+-void MQTTRun(void* parm)
++void *MQTTRun(void* parm)

This can be done without a patch, by making the thread-handler part of `riot_iface.c` and just calling `MQTTRun()` from it

```C
void *_mqtt_run(void *args)
{
    MQTTRun(args);  /* never returns */
    return NULL
}
```

Patches should be avoided for packages, if possible.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12647#pullrequestreview-409130773
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200511/ac1a598d/attachment.htm>


More information about the notifications mailing list