[riot-notifications] [RIOT-OS/RIOT] gnrc_ipv6_nib: only add prefix of same interface to ABR (#13740)

benpicco notifications at github.com
Tue May 12 11:44:46 CEST 2020


@benpicco commented on this pull request.



>      _nib_acquire();
     if ((abr = _nib_abr_add(addr)) == NULL) {
         _nib_release();
         return -ENOMEM;
     }
     abr->valid_until = 0U;
+    /* Associate all existing prefixes in the prefix list of the border router's
+     * downstream interface to the authoritative border router so they are
+     * advertised with the ABRO in a respective PIO. */

> a person reading this code and not knowing what a PIO is, has no business reading this code, because I expect at least a passing familiarity with RFC 4861 and 6775.

I strongly object such notion.
If someone is tracing the code to track down some weird bug, we should make their life easier, not harder.
Throwing in a few breadcrumbs will not hurt. And even when grepping for the lowercase version, `pio` is never resolved.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/13740#discussion_r423604005
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200512/58a0a19c/attachment.htm>


More information about the notifications mailing list