[riot-notifications] [RIOT-OS/RIOT] nrf52: Implement EasyDMA-based SPI peripheral implemenation (#14057)

Koen Zandberg notifications at github.com
Tue May 12 12:16:10 CEST 2020


@bergzand commented on this pull request.



> @@ -36,7 +36,9 @@ static const spi_conf_t spi_config[] = {
         .sclk = GPIO_PIN(0, 15),
         .mosi = GPIO_PIN(0, 13),
         .miso = GPIO_PIN(0, 14),
+#ifdef ERRATA_SPI_SINGLE_BYTE_WORKAROUND
         .ppi = 0,

Somebody modifying this instantiation to multiple SPI configs for his own board and not noticing that the `.ppi` should be added, and thus having only one functional SPI bus.

Same as that a PPI channel is also explicitly set [here] while that one could also be omitted

[here]: https://github.com/RIOT-OS/RIOT/blob/master/boards/nrf51dk/include/periph_conf.h#L68

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/14057#discussion_r423622305
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200512/1e9cb7b3/attachment.htm>


More information about the notifications mailing list