[riot-notifications] [RIOT-OS/RIOT] net/gnrc_netif_lorawan: fix unaligned copy (#14058)
notifications at github.com
Tue May 12 13:45:54 CEST 2020
The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.
### Contribution description
This PR fixes an unaligned copy when setting the Device Address. The address array is not necessarily aligned because it's an `uint8_t` array, so parsing that to `uint32_t` might violate aligned memory access in Cortex M.
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes
### Testing procedure
I got these weird hardfaults while refactoring `gnrc_lorawan`. I'm not sure if it's easy to reproduce the crash, but at least it should be enough to run `examples/gnrc_lorawan` and make sure it still joins, sends, etc.
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output
### Issues/PRs references
None so far
Examples: Fixes #1234. See also #5678. Depends on PR #9876.
Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* net/gnrc_netif_lorawan: fix unaligned copy
-- File Changes --
M sys/net/gnrc/netif/lorawan/gnrc_netif_lorawan.c (3)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications