[riot-notifications] [RIOT-OS/RIOT] net/gnrc_netif_lorawan: fix unaligned copy (#14058)

Martine Lenders notifications at github.com
Tue May 12 13:51:49 CEST 2020


@miri64 commented on this pull request.



> +    uint32_t tmp;
+    memcpy(&tmp, be_addr, sizeof(uint32_t));
     tmp = byteorder_swapl(tmp);

I'd prefer if a 32-bit variant of `static inline uint16_t byteorder_bebuftohs(const uint8_t *buf);` were added to `core/include/byteorder.h` for that and used here.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/14058#pullrequestreview-409962433
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200512/fd7800ca/attachment-0001.htm>


More information about the notifications mailing list