[riot-notifications] [RIOT-OS/RIOT] cpu/cortexm_common: add inlined header only def for irq_% (#13999)

Marian Buschsieweke notifications at github.com
Tue May 12 14:53:21 CEST 2020


@maribu commented on this pull request.



>  
 #ifdef __cplusplus
 extern "C" {
 #endif
 
+#ifdef LEGACY_IRQ_API

>  Less surprising to anyone having an arch outside riot.

Let us please not worry about out of tree archs. Maintaining and deprecating RIOTs public APIs is already enough pain in the ass and a significant toll in the development process; but for official APIs this is certainly justified. Worrying about breaking out-of-tree code that touches RIOT's internals is IMO really off limits.

Before the next release we should be done with the conversion. And IMO that is the point we should get rid of `IRQ_API_INLINED` or `LEGACY_IRQ_API`. So next release, out-of-tree archs would have to follow suit. Or better: Being PR'ed to get upstream and benefit from being maintained by the community.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/13999#discussion_r423707798
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200512/96fe53f1/attachment.htm>


More information about the notifications mailing list