[riot-notifications] [RIOT-OS/RIOT] cpu/cortexm_common: add inlined header only def for irq_% (#13999)

Francisco notifications at github.com
Tue May 12 15:09:43 CEST 2020


@fjmolinas commented on this pull request.



>  
 #ifdef __cplusplus
 extern "C" {
 #endif
 
+#ifdef LEGACY_IRQ_API

I personally don't mind either way, I was about to push the requested change. As I see it `LEGACY_IRQ_API` means touching more stuff now, but none at the end of the process, `IRQ_API_INLINED` means touching less stuff now, and all the platforms at the end. But if we actually change them all by the release `MAYBE_INLINE` would also be removed, having it as a place holder just reduces duplicated lines during migration. So IMO not much is gained or lost by any of the approaches.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/13999#discussion_r423718690
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200512/622c860c/attachment.htm>


More information about the notifications mailing list