[riot-notifications] [RIOT-OS/RIOT] gnrc/nib: add NIB event bus (#14022)

Martine Lenders notifications at github.com
Tue May 12 15:43:07 CEST 2020


@miri64 commented on this pull request.

Looking good so far. Some nits to the doc. Let me do some testing also.

> @@ -288,6 +288,24 @@ enum {
     GNRC_IPV6_NIB_ROUTE_INFO_TYPE_NSC,
 };
 
+/**
+ * @brief   Types for GNRC_NETIF_BUS_NIB per-interface message bus
+ */
+typedef enum {
+    /**
+     * @brief   Address becomes valid
+     *
+     * The event is generated when an address on the interface becomes valid.
+     * The message payload contains a pointer to the respective
+     * @ref ipv6_addr_t struct.
+     *
+     * <b>Note:</b> If the address on the interface changed between sending

```suggestion
     * @note If the address on the interface changed between sending
```

> @@ -288,6 +288,24 @@ enum {
     GNRC_IPV6_NIB_ROUTE_INFO_TYPE_NSC,
 };
 
+/**
+ * @brief   Types for GNRC_NETIF_BUS_NIB per-interface message bus
+ */
+typedef enum {
+    /**
+     * @brief   Address becomes valid
+     *
+     * The event is generated when an address on the interface becomes valid.

Maybe also add a note, that this does not fire, if the address is added manually with VALID set.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/14022#pullrequestreview-410052172
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200512/fffa8c28/attachment-0001.htm>


More information about the notifications mailing list