[riot-notifications] [RIOT-OS/RIOT] sock_dtls: add timeout to sock_dtls_send and sock_dtls_session_create (#14043)

Martine Lenders notifications at github.com
Wed May 13 15:04:09 CEST 2020


@miri64 commented on this pull request.

Some style nits to your style fixes ;-)

> +                           SOCK_NO_TIMEOUT) < 0)
+        {

```suggestion
                           SOCK_NO_TIMEOUT) < 0) {
```

> +        if ((msg_try_receive(&msg) == 1) && (msg.type == DTLS_STOP_SERVER_MSG))
+        {

```suggestion
        if ((msg_try_receive(&msg) == 1) &&
            (msg.type == DTLS_STOP_SERVER_MSG)) {
```

> @@ -463,7 +465,7 @@ static void _session_to_ep(const session_t *session, sock_udp_ep_t *ep)
     memcpy(&ep->addr.ipv6, &session->addr, sizeof(ipv6_addr_t));
 }
 
-static uint32_t _update_timeout(uint32_t start, uint32_t timeout) {
+static inline uint32_t _update_timeout(uint32_t start, uint32_t timeout) {

```suggestion
static inline uint32_t _update_timeout(uint32_t start, uint32_t timeout)
{
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/14043#pullrequestreview-410899772
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200513/2f71bd5e/attachment.htm>


More information about the notifications mailing list