[riot-notifications] [RIOT-OS/RIOT] drivers/at : Expose Configurations to Kconfig (#14019)

Leandro Lanzieri notifications at github.com
Thu May 14 16:11:47 CEST 2020


@leandrolanzieri requested changes on this pull request.



> @@ -57,12 +58,26 @@ extern "C" {
 #define AT_SEND_EOL "\r"
 #endif
 
+/**
+ * @brief Disable echo after an AT command is sent.

```suggestion
 * @brief Disable the expected echo after an AT command is sent.
```

> +config AT_SEND_EOL_UNIX
+    bool "\\n"
+
+config AT_SEND_EOL_MAC
+    bool "\\r"
+
+endchoice
+
+config AT_SEND_SKIP_ECHO
+    bool "Disable check for echo"
+    help
+        Enable this to disable check for echo after an AT
+        command is sent.
+
+config AT_RECV_OK
+    string "Default ok reply"

```suggestion
    string "OK reply string"
```

> +endchoice
+
+config AT_SEND_SKIP_ECHO
+    bool "Disable check for echo"
+    help
+        Enable this to disable check for echo after an AT
+        command is sent.
+
+config AT_RECV_OK
+    string "Default ok reply"
+    default "OK"
+    help
+        Change default okay response of the AT device.
+
+config AT_RECV_ERROR
+    string "Default error reply"

```suggestion
    string "Error reply string"
```

> +config AT_SEND_EOL_MAC
+    bool "\\r"
+
+endchoice
+
+config AT_SEND_SKIP_ECHO
+    bool "Disable check for echo"
+    help
+        Enable this to disable check for echo after an AT
+        command is sent.
+
+config AT_RECV_OK
+    string "Default ok reply"
+    default "OK"
+    help
+        Change default okay response of the AT device.

```suggestion
        Change okay response of the AT device.
```

> +    bool "Disable check for echo"
+    help
+        Enable this to disable check for echo after an AT
+        command is sent.
+
+config AT_RECV_OK
+    string "Default ok reply"
+    default "OK"
+    help
+        Change default okay response of the AT device.
+
+config AT_RECV_ERROR
+    string "Default error reply"
+    default "ERROR"
+    help
+        Change default error response of the AT device.

```suggestion
        Change error response of the AT device.
```

>  
 /**
- * @brief default OK reply of an AT device.
+1st end of line character received (S3 aka CR character for a modem).

Why remove the `@brief`? (here and bellow)

>  
 /** Shortcut for getting send end of line length */
-#define AT_SEND_EOL_LEN  (sizeof(AT_SEND_EOL) - 1)
+#define AT_SEND_EOL_LEN  (sizeof(CONFIG_AT_SEND_EOL) - 1)
 
 #if defined(MODULE_AT_URC) || DOXYGEN
 #ifndef AT_BUF_SIZE

It seems you are missing this option

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/14019#pullrequestreview-411835946
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200514/207e0dd9/attachment.htm>


More information about the notifications mailing list