[riot-notifications] [RIOT-OS/RIOT] drivers/at : Expose Configurations to Kconfig (#14019)

Leandro Lanzieri notifications at github.com
Fri May 15 14:31:57 CEST 2020


@leandrolanzieri commented on this pull request.



>  #endif
 
 /**
- * @brief default OK reply of an AT device.
+ * @brief Size of buffer used to process unsolicited result code data.
+ */
+#if defined(MODULE_AT_URC) || DOXYGEN
+#if defined(MODULE_AT_URC) || DOXYGEN

Duplicated?

> +#ifdef CONFIG_AT_BUF_SIZE_EXP
+#define CONFIG_AT_BUF_SIZE  (1<<CONFIG_AT_BUF_SIZE_EXP)
+#endif

I think this could be like this
```suggestion
#ifdef CONFIG_AT_BUF_SIZE_EXP
#define CONFIG_AT_BUF_SIZE_EXP (7)
#endif

#define AT_BUF_SIZE   (1<<CONFIG_AT_BUF_SIZE_EXP)
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/14019#pullrequestreview-412603827
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200515/0899edf6/attachment.htm>


More information about the notifications mailing list