[riot-notifications] [RIOT-OS/RIOT] sys/evtimer: introduce ZTIMER_MSEC as timer backend (#13661)

Juergen Fitschen notifications at github.com
Sat May 16 21:20:21 CEST 2020


@jue89 commented on this pull request.



> +# make evtimer use ztimer_msec as low level timer
+ifneq (,$(filter evtimer_on_ztimer,$(USEMODULE)))
+  USEMODULE += ztimer_msec
+  PSEUDOMODULES += evtimer_on_ztimer
+endif
+

After I slept over it, I would prefer to have the whole dependency resolution for `xtimer` resp. `evtimer` at one place. Currently, for `xtimer` one half can be found in `Makefile.dep` and the other half at `sys/ztimer/Makefile.dep`. (Maybe @kaspar030 has a good reason for that?)

I think the best way is to open another PR fixing this for `xtimer`. Do you agree?

Another question, that just came into my mind: Why is most of the `sys/*` dependency resolution handled in the `Makefile.dep` and not in the `sys/Makefile.dep`? Is there a reason for that? I find this a little bit confusing.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/13661#discussion_r426182725
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200516/d40a8b00/attachment.htm>


More information about the notifications mailing list