[riot-notifications] [RIOT-OS/RIOT] drivers/at : Expose Configurations to Kconfig (#14019)

Leandro Lanzieri notifications at github.com
Mon May 18 15:48:40 CEST 2020


@leandrolanzieri commented on this pull request.



> @@ -33,4 +33,8 @@ menu "Storage Device Drivers"
 rsource "mtd_sdcard/Kconfig"
 endmenu # Storage Device Drivers
 
+menu "Miscellaneous Device Drivers"

Do you mind moving this before "Network Device Drivers"? 

>  
-/** Shortcut for getting send end of line length */
-#define AT_SEND_EOL_LEN  (sizeof(AT_SEND_EOL) - 1)
+/**
+ * @brief 1st end of line character received (S3 aka CR character for a modem).
+ */
+#ifndef AT_RECV_EOL_1
+#define AT_RECV_EOL_1   "\r"

Why these two are not in Kconfig?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/14019#pullrequestreview-413579314
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200518/c9b425f9/attachment.htm>


More information about the notifications mailing list