[riot-notifications] [RIOT-OS/RIOT] pkg/openwsn: re-integrate the network stack as a package (#13824)

Francisco notifications at github.com
Tue May 19 10:54:46 CEST 2020


@fjmolinas commented on this pull request.



> +   slot */
+#ifndef SLOTDURATION
+#define SLOTDURATION        20        /* in miliseconds */
+#endif
+
+/* These parameters are BOARD and CPU specific.
+   Values cant be taken directly from OpenWSN since they do not necessarily use
+   the same BSP configuration (timers, clock speed, etc.)
+   For precise synchronization these values should be measured and tuned for
+   every BOARD.
+   To understand the relationship between these values and OpenWSN state machine
+   look at:
+   https://openwsn.atlassian.net/wiki/spaces/OW/pages/688251/State+Machine
+*/
+#if SLOTDURATION == 20
+#ifndef PORT_TsSlotDuration     /* 655 ticks at @32768Hz */

Just as a note I do not like this define based approach, but currently the code expects these defines to exist. There is some refactoring going on upstream where this are changed to a structure based approach, but there i no clear ETA, so I'll adapt to that once the change is in upstream.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/13824#pullrequestreview-414238254
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200519/a73de42e/attachment.htm>


More information about the notifications mailing list