[riot-notifications] [RIOT-OS/RIOT] sys/evtimer: introduce ZTIMER_MSEC as timer backend (#13661)

Marian Buschsieweke notifications at github.com
Tue May 19 14:32:35 CEST 2020


> But in case of the conditional `PSEUDOMODULES += xtimer` I don't see any other solution to pull `PSEUDOMODULES` into the dependency resolution process and deduplicate und sort it, as well.

Oh yes, a module this is only conditionally a pseudo-module is indeed a special case. The approach @fjmolinas suggested would certainly work. Maybe it could be simplified to this:

```Makefile
ifneq (,$(filter xtimer_on_xtimer,$(USEMODULE)))
  NO_AUTO_SRC = 1
endif
```

Alternatively, this special case IMO justifies an exception. A small comment above the `PSEUDOMODULES +=` outside of `pseudomodules.mk` to state the reasons for this would be greatly appreciated. This would prevent it for becoming a role model for touching `PSEUDOMODULES` during dependency resolution.

I don't think that de-duplication of `PSEUDOMODULES` would actually be needed. If I recall correctly, we only access it using `$(filter <FOO>,$(PSEUDOMODULES))`; and for that it does not matter if it contains duplicates. (Deduplication might improve performance if the array would contain many duplicates, though. But that is not the case here.)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/13661#issuecomment-630787017
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200519/cb07e782/attachment.htm>


More information about the notifications mailing list